feat: 공유하기 모달 구현 #212
Merged
feat: 공유하기 모달 구현 #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
Soohyuniii
reviewed
Apr 23, 2025
| useEffect(() => { | ||
| // 카카오톡 SDK 초기화 | ||
| if (window.Kakao && !window.Kakao.isInitialized()) { | ||
| window.Kakao.init("a4816c8b85267871796431d92ed23451"); |
Collaborator
There was a problem hiding this comment.
키값을 환경변수로 사용해야 할 것 같습니다!
Collaborator
There was a problem hiding this comment.
추가적으로 환경변수는 api쪽이 아니라 저희 쪽에서도 등록 가능합니다!
src/components/button/UrlCopyBar.tsx
Outdated
| @@ -0,0 +1,14 @@ | |||
| import UrlCopyButton from "./UrlCopyButton"; | |||
src/components/modal/ShareModal.tsx
Outdated
| @@ -0,0 +1,66 @@ | |||
| import { useEffect, useState } from "react"; | |||
| import UrlCopyBar from "@/components/button/UrlCopyBar"; | |||
| import KakaoShareButton from "../button/KakaoShareButton"; | |||
| import { StrictMode } from "react"; | ||
| import { createRoot } from "react-dom/client"; | ||
| import "./index.css"; | ||
| import App from "./App"; |
Collaborator
Author
|
PR 내용이 많이 바뀌어 다시 확인 부탁드립니다! |
Soohyuniii
reviewed
Apr 23, 2025
| <button onClick={handleShare}> | ||
| <img | ||
| src="/icon/kakaotalk.svg" | ||
| alt="카카오통 공유하기 버튼" |
src/components/modal/ShareModal.tsx
Outdated
| @@ -0,0 +1,66 @@ | |||
| import { useEffect, useState } from "react"; | |||
| import UrlCopyBar from "@/components/button/UrlCopyBar"; | |||
| import KakaoShareButton from "../button/KakaoShareButton"; | |||
Collaborator
Author
|
반영했습니다! |
Soohyuniii
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull requests
✅ 작업한 내용
🔢 #178
❗️PR Point
📸 스크린샷
Result.mov
SubHeader.mov